Review Request 120778: Only show the list of hidden system tray items when a hidden item is expanded
Marco Martin
notmart at gmail.com
Fri Oct 24 15:13:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120778/#review69105
-----------------------------------------------------------
Ok, actually tried the patch.
seems sensible, tough it seems to make more noticeable a bit of a weird alignment of the top title.
maybe this can be pushed and then have visual adjustments later
- Marco Martin
On Oct. 24, 2014, 1:18 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120778/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 1:18 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Only show the list of hidden system tray items when a hidden item is expanded
>
> As discussed on the forums
> https://forum.kde.org/viewtopic.php?f=285&t=122794&sid=5d2a526b8f6146b1f52f0c75b7600871
>
> FEATURE: 334823
>
>
> Diffs
> -----
>
> applets/systemtray/package/contents/ui/ExpandedRepresentation.qml e938ec6
>
> Diff: https://git.reviewboard.kde.org/r/120778/diff/
>
>
> Testing
> -------
>
> Matches the mockups
>
> Opened non hidden item
> Opened hidden item from arrow, and selected some
> Tested opening the battery plasmoid then plugging/unplugging to make it hide/not. Everything all looks OK.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141024/c35d34d5/attachment.html>
More information about the Plasma-devel
mailing list