Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68848
-----------------------------------------------------------

Ship it!


Looking mostly good to my eyes.


misc/gtkbreeze/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120624/#comment48150>

    off-hand, I don't see why we need QWidgets here. Can you check?



misc/gtkbreeze/main.cpp
<https://git.reviewboard.kde.org/r/120624/#comment48149>

    QDir::separator() here as well



misc/gtkbreeze/main.cpp
<https://git.reviewboard.kde.org/r/120624/#comment48148>

    if setGtk2 fails and setGtk3 succeeds, it will return success. It should probably return success only if both failed.


- Sebastian Kügler


On Oct. 21, 2014, 10 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 10 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -----
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> -------
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141021/b294bd40/attachment-0001.html>