Review Request 120577: Remove shutdown option from lockscreen's look and feel
David Edmundson
david at davidedmundson.co.uk
Mon Oct 20 08:42:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/#review68744
-----------------------------------------------------------
+1. and +1 for putting in 5.1 too.
I don't really agree with you on the suspend discussion but it's clear we're not going anywhere on that soon and it shouldn't hold up removing shutdown which I think we do all agree on.
- David Edmundson
On Oct. 20, 2014, 5:59 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120577/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 5:59 a.m.)
>
>
> Review request for Plasma and Aleix Pol Gonzalez.
>
>
> Bugs: 339453
> https://bugs.kde.org/show_bug.cgi?id=339453
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Logging out from the locked screen is impossible. Logging out means
> interaction with the session due to the session manager. The session
> manager asks all applications to quit and applications are allowed to
> ask for example saving changes. The session manager stopps the
> logout in this case and asks the window manager to focus this window
> and the session manager will only continue the logout once the
> application resolved the situation. At any time in this process the
> user is still able to abort the logout!
>
> Switching to the application which needs interaction is impossible,
> though as the screen is still locked. The result is a seemingly
> frozen system as the logout cannot continue and there is no indication
> what is going on.
>
> Of course the lock screen cannot unlock the session for the logout as
> that would circumvent the security. If the lock screen would unlock
> one would just have to click the button and abort the logout really
> fast to have the system unlocked. So this is clearly not an option.
>
> The result is: we cannot implement this functionality in a working
> and secure manner, so it's better to remove it.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.cpp fd1d20b824dd7781cb5c2e96895694f290a46877
> lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d
> ksmserver/screenlocker/greeter/greeterapp.h f3033c701fb3c3ce5fa8f12f58ee8c6af739444b
>
> Diff: https://git.reviewboard.kde.org/r/120577/diff/
>
>
> Testing
> -------
>
> run kscreenlocker_greeter --testing and locked the screen - button is gone.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141020/75642fe6/attachment.html>
More information about the Plasma-devel
mailing list