Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
David Edmundson
david at davidedmundson.co.uk
Sun Oct 19 15:47:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68708
-----------------------------------------------------------
misc/gtkbreeze/main.cpp
<https://git.reviewboard.kde.org/r/120624/#comment47901>
mid-long term we probably want to split this out into a file that we copy
Otherwise this isn't really going to scale especially wrt GTK Config and changing themes later.
misc/gtkbreeze/main.cpp
<https://git.reviewboard.kde.org/r/120624/#comment47902>
do we even need the app? we're not using it.
- David Edmundson
On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2014, 3:15 p.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: breeze
>
>
> Description
> -------
>
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
>
>
> Diffs
> -----
>
> misc/CMakeLists.txt ff891a9
> misc/gtkbreeze/CMakeLists.txt PRE-CREATION
> misc/gtkbreeze/gtkbreeze.upd PRE-CREATION
> misc/gtkbreeze/main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
>
>
> Testing
> -------
>
> run it and run gtk-demo and gtk3-demo
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141019/4b732db5/attachment.html>
More information about the Plasma-devel
mailing list