Review Request 120604: Cleanup applet configuration scrollbar handling
Marco Martin
notmart at gmail.com
Thu Oct 16 14:32:54 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120604/#review68558
-----------------------------------------------------------
Ship it!
Inviala!
- Marco Martin
On Ott. 16, 2014, 1:14 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120604/
> -----------------------------------------------------------
>
> (Updated Ott. 16, 2014, 1:14 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 336533 and 337298
> https://bugs.kde.org/show_bug.cgi?id=336533
> https://bugs.kde.org/show_bug.cgi?id=337298
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This cleans up the applet configuration scrollbar handling which does away with the spurious binding loop on the Column and binds the StaackView height to the viewport height instead of the item height doing away with the glitching scrollbar appearance.
>
> Also gets rid of some useless anchors.
>
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/AppletConfiguration.qml 6c4b7f5
>
> Diff: https://git.reviewboard.kde.org/r/120604/diff/
>
>
> Testing
> -------
>
> No more binding loop warning (as far as I could see it in the verbose console output), no more once in a while appearing scrollbars when resizing dialogs smaller.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141016/1fab0bba/attachment-0001.html>
More information about the Plasma-devel
mailing list