Review Request 120577: Remove shutdown option from lockscreen's look and feel

[David Edmundson]

> On Oct. 15, 2014, 6:30 p.m., David Edmundson wrote:
> > Relevant code in greeterapp needs removing too.
> > There's a property and a slot ::shutdown()
> > 
> > Interestingly the canShutDown is based on whether the user can logout which is a bit random.
> 
> Martin Gräßlin wrote:
>     > Relevant code in greeterapp needs removing too.
>     
>     all right, will update.
>     
>     > Interestingly the canShutDown is based on whether the user can logout which is a bit random.
>     
>     yeah, I thought so as well when reading the documentation. What would be cool is to tell logind that currently the screen is locked and that logind behaves like there is no active session in that case. Maybe worth to take to their mailing list?

We already do tell logind that the session is locked (or at least we should be), but as you pointed out earlier canShutdown is user based not session based so it doesn't really end up helping.

It's worth an email, they might have a plan or at least they would want to know where logind maybe misses something for when they make v2.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/#review68501
-----------------------------------------------------------


On Oct. 14, 2014, 9:45 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120577/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 9:45 a.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Bugs: 339453
>     https://bugs.kde.org/show_bug.cgi?id=339453
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Logging out from the locked screen is impossible. Logging out means
> interaction with the session due to the session manager. The session
> manager asks all applications to quit and applications are allowed to
> ask for example saving changes. The session manager stopps the
> logout in this case and asks the window manager to focus this window
> and the session manager will only continue the logout once the
> application resolved the situation. At any time in this process the
> user is still able to abort the logout!
> 
> Switching to the application which needs interaction is impossible,
> though as the screen is still locked. The result is a seemingly
> frozen system as the logout cannot continue and there is no indication
> what is going on.
> 
> Of course the lock screen cannot unlock the session for the logout as
> that would circumvent the security. If the lock screen would unlock
> one would just have to click the button and abort the logout really
> fast to have the system unlocked. So this is clearly not an option.
> 
> The result is: we cannot implement this functionality in a working
> and secure manner, so it's better to remove it.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d 
> 
> Diff: https://git.reviewboard.kde.org/r/120577/diff/
> 
> 
> Testing
> -------
> 
> run kscreenlocker_greeter --testing and locked the screen - button is gone.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/ca946659/attachment-0001.html>