Review Request 120602: Fix glitching Alternatives dialog

Wed Oct 15 20:23:28 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120602/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.

Bugs: 340003
    https://bugs.kde.org/show_bug.cgi?id=340003

Repository: plasma-desktop

Description
-------

Fixes a porting oversight and also takes into account the buttons and heading.

Apparently when a dialog does not explicitly set a mainItem, the Dialog tries to guess the size from the children of the dialog which was anchors.fill and then it got confused.

Diffs
-----

  desktoppackage/contents/explorer/AppletAlternatives.qml 4e97dc9 

Diff: https://git.reviewboard.kde.org/r/120602/diff/

Testing
-------

Dialog flies in smoothly trying to display the list without scrollbars but is still properly max'd to not fill the entire screen.

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/ba30ec00/attachment.html>