Review Request 120584: Don't position the panel until it's about to be displayed

Aleix Pol Gonzalez aleixpol at kde.org
Wed Oct 15 15:15:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 3:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 339672
    https://bugs.kde.org/show_bug.cgi?id=339672


Repository: plasma-workspace


Description
-------

I was getting the Panels wrongly positioned because Qt would reset the position at some point while initializing the class. This patch disables any position while the panel is not shown and makes sure it's placed when it's set to be shown.


Diffs
-----

  shell/panelview.cpp 9260c18 
  shell/shellcorona.cpp ba66d46 

Diff: https://git.reviewboard.kde.org/r/120584/diff/


Testing
-------

Both my installations initialize properly now.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/e0049170/attachment.html>


More information about the Plasma-devel mailing list