Review Request 120584: Don't position the panel until it's about to be displayed

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/#review68455
-----------------------------------------------------------


I consider it as highly unlikely that KWin positioned the panel unless it (or Qt) was doing something wrong. The panel should request a position and KWin honors that and as it's a panel there is nothing which should make KWin in applying any rules.

Anyway: if you have the feeling it could be KWin I recommend to pick a different window manager for the test (e.g. OpenBox). If you see the same or similar results one can rule out the WM.

- Martin Gräßlin


On Oct. 15, 2014, 3:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120584/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 339672
>     https://bugs.kde.org/show_bug.cgi?id=339672
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I was getting the Panels wrongly positioned because Qt would reset the position at some point while initializing the class. This patch disables any position while the panel is not shown and makes sure it's placed when it's set to be shown.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 9260c18 
>   shell/shellcorona.cpp ba66d46 
> 
> Diff: https://git.reviewboard.kde.org/r/120584/diff/
> 
> 
> Testing
> -------
> 
> Both my installations initialize properly now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/b5f9e3ff/attachment.html>