Review Request 120597: Fix warnings
Marco Martin
notmart at gmail.com
Wed Oct 15 11:00:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120597/#review68446
-----------------------------------------------------------
Ship it!
Inviala!
- Marco Martin
On Ott. 15, 2014, 10:58 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120597/
> -----------------------------------------------------------
>
> (Updated Ott. 15, 2014, 10:58 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Whenever showing the panel settings I got this warning:
> file:///home/kde-devel/kde5/share/plasma/shells/org.kde.plasma.desktop/contents/views/Panel.qml:183: ReferenceError: minimumWidthChanged is not defined
>
> This patch fixes this warning and also some rendering issues in the panel's settings dialog, where the buttons would have different sizes when laid out vertically.
>
>
> Diffs
> -----
>
> desktoppackage/contents/views/Panel.qml e05d3b9
>
> Diff: https://git.reviewboard.kde.org/r/120597/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/3832ce49/attachment.html>
More information about the Plasma-devel
mailing list