Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 10:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin.


Repository: kdeclarative


Description
-------

Moves the caching types used in Plasma Workspace into a QuickAddons submodule.

Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures.


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 
  src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f 
  src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 
  src/quickaddons/CMakeLists.txt PRE-CREATION 
  src/quickaddons/imagetexturescache.h PRE-CREATION 
  src/quickaddons/imagetexturescache.cpp PRE-CREATION 
  src/quickaddons/managedtexturenode.h PRE-CREATION 
  src/quickaddons/managedtexturenode.cpp PRE-CREATION 
  tests/qiconitem_test.qml PRE-CREATION 
  src/CMakeLists.txt eb0dfd3 

Diff: https://git.reviewboard.kde.org/r/120550/diff/


Testing
-------

I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/11976e41/attachment.html>