Review Request 120584: Don't position the panel until it's about to be displayed

Martin Gräßlin mgraesslin at kde.org
Tue Oct 14 16:27:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/#review68400
-----------------------------------------------------------


looks like a useful change to me (and I hope it fixes the mispositioning I experienced today when restarting the system ;-) )

- Martin Gräßlin


On Oct. 14, 2014, 6:15 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120584/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 6:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I was getting the Panels wrongly positioned because Qt would reset the position at some point while initializing the class. This patch disables any position while the panel is not shown and makes sure it's placed when it's set to be shown.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 9260c18 
> 
> Diff: https://git.reviewboard.kde.org/r/120584/diff/
> 
> 
> Testing
> -------
> 
> Both my installations initialize properly now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141014/00b9a76e/attachment.html>


More information about the Plasma-devel mailing list