Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

Aleix Pol Gonzalez aleixpol at kde.org
Tue Oct 14 13:46:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 1:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.

This makes Plasma crash when a plasmoid is loaded.


Diffs
-----

  src/plasmaquick/appletquickitem.cpp 45055a5 

Diff: https://git.reviewboard.kde.org/r/120581/diff/


Testing
-------

Doesn't crash anymore.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141014/507c23fa/attachment.html>


More information about the Plasma-devel mailing list