Review Request 120577: Remove shutdown option from lockscreen's look and feel

[Martin Gräßlin]

> On Oct. 14, 2014, 12:34 p.m., Aleix Pol Gonzalez wrote:
> > I think it's unfortunate, you're giving a mix of technical and usability reasons to back your patch. In any case, I understand that the bug needs to be solved and if this is what it takes, then do it.
> > 
> > FWIW, I also think suspend would be good here.
> 
> Martin Gräßlin wrote:
>     Just out of interest: where am I mixing technical and usability reasons? To me the commit message sounds only technical.
> 
> Aleix Pol Gonzalez wrote:
>     Well, it's not like it's not possible to shutdown from the lock screen. Many OS have done that in the past, thinking of Android, Windows (XP?), etc. So we can fix that, or disable it. So that's technical, while removing the functionality is the usability way to solve things.
>     
>     Disabling it is efficient on the other hand, because we already have this patch.

ok, I understand what you mean. But I think the comparison to other OS doesn't really fit as we have the session management and interaction. Android is designed differentelly with each application having to expect that it gets killed at any time anyway.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/#review68374
-----------------------------------------------------------


On Oct. 14, 2014, 11:45 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120577/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:45 a.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Bugs: 339453
>     https://bugs.kde.org/show_bug.cgi?id=339453
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Logging out from the locked screen is impossible. Logging out means
> interaction with the session due to the session manager. The session
> manager asks all applications to quit and applications are allowed to
> ask for example saving changes. The session manager stopps the
> logout in this case and asks the window manager to focus this window
> and the session manager will only continue the logout once the
> application resolved the situation. At any time in this process the
> user is still able to abort the logout!
> 
> Switching to the application which needs interaction is impossible,
> though as the screen is still locked. The result is a seemingly
> frozen system as the logout cannot continue and there is no indication
> what is going on.
> 
> Of course the lock screen cannot unlock the session for the logout as
> that would circumvent the security. If the lock screen would unlock
> one would just have to click the button and abort the logout really
> fast to have the system unlocked. So this is clearly not an option.
> 
> The result is: we cannot implement this functionality in a working
> and secure manner, so it's better to remove it.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d 
> 
> Diff: https://git.reviewboard.kde.org/r/120577/diff/
> 
> 
> Testing
> -------
> 
> run kscreenlocker_greeter --testing and locked the screen - button is gone.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141014/bbbaa6a2/attachment.html>