Review Request 120577: Remove shutdown option from lockscreen's look and feel
Martin Gräßlin
mgraesslin at kde.org
Tue Oct 14 07:32:31 UTC 2014
> On Oct. 14, 2014, 9:02 a.m., Martin Klapetek wrote:
> > Could we possibly get "Suspend" button instead? Suspend stores the session state into memory and then restores it without any issues (and we lock screen on wakeup anyway); many times I have found my laptop with locked screen and I had to unlock, click the suspend button in the panel only to get it locked again and suspended.
>
> Martin Gräßlin wrote:
> I expected this question to come :-) - I'm not sure whether it's a valid use case, at least for laptops. Closing the lid should send it to suspend, the suspend button should still work (if not, we should fix it). So there are already quite some decent ways to get the system to suspend when locked. Especially with lid closing it does what it's supposed to do.
>
> In fact the functionality should even be available through the Change Session functionality as that drops you to the login manager where you can suspend. Sure not as comfortable as directly exposing it. But we don't need to expose every option which might make sense ;-)
>
> Kai Uwe Broulik wrote:
> Although closing the lid apparently reliably suspends the device, even when locked, my gut makes me not trust it. :/
> Although closing the lid apparently reliably suspends the device, even when locked, my gut makes me not trust it. :/
At least my notebook(s) have a visible LED indicating it is in sleep mode.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/#review68345
-----------------------------------------------------------
On Oct. 14, 2014, 7:41 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120577/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 7:41 a.m.)
>
>
> Review request for Plasma and Aleix Pol Gonzalez.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Logging out from the locked screen is impossible. Logging out means
> interaction with the session due to the session manager. The session
> manager asks all applications to quit and applications are allowed to
> ask for example saving changes. The session manager stopps the
> logout in this case and asks the window manager to focus this window
> and the session manager will only continue the logout once the
> application resolved the situation. At any time in this process the
> user is still able to abort the logout!
>
> Switching to the application which needs interaction is impossible,
> though as the screen is still locked. The result is a seemingly
> frozen system as the logout cannot continue and there is no indication
> what is going on.
>
> Of course the lock screen cannot unlock the session for the logout as
> that would circumvent the security. If the lock screen would unlock
> one would just have to click the button and abort the logout really
> fast to have the system unlocked. So this is clearly not an option.
>
> The result is: we cannot implement this functionality in a working
> and secure manner, so it's better to remove it.
>
>
> Diffs
> -----
>
> lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d
>
> Diff: https://git.reviewboard.kde.org/r/120577/diff/
>
>
> Testing
> -------
>
> run kscreenlocker_greeter --testing and locked the screen - button is gone.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141014/e865c061/attachment.html>
More information about the Plasma-devel
mailing list