Review Request 120471: Add Registry::sync() signal
Martin Gräßlin
mgraesslin at kde.org
Tue Oct 14 04:57:51 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120471/#review68340
-----------------------------------------------------------
Ship it!
looks good
- Martin Gräßlin
On Oct. 14, 2014, 4:17 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120471/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 4:17 a.m.)
>
>
> Review request for kwin, Plasma and Martin Gräßlin.
>
>
> Repository: kwayland
>
>
> Description
> -------
>
> Add Registry::sync() signal
>
> Emitted when the Wayland display is done flushing the initial interface
> callbacks, announcing wl_display properties. This can be used to compress
> events. Note that this signal is emitted only after announcing interfaces,
> such as outputs, but not after receiving callbacks of interface properties,
> such as the output's geometry, modes, etc..
> This signal is emitted from the wl_display_sync callback.
>
> For this, we add a wl_callback_listener to the registry's Private,
> enqueue its events properly, if necessary, and trigger the signal
> through a callback mechanism similar to the wl_registry callbacks.
>
> This signal allows users of the API to find out when the signal
> emissions, such as outputAnnounced, etc. for all currently existing
> interfaces is complete.
>
>
> Diffs
> -----
>
> autotests/client/test_wayland_registry.cpp 571be0f
> src/client/registry.h 9e63a2b
> src/client/registry.cpp 207cdef
>
> Diff: https://git.reviewboard.kde.org/r/120471/diff/
>
>
> Testing
> -------
>
> tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141014/1ba0c07e/attachment.html>
More information about the Plasma-devel
mailing list