Review Request 120565: Save the default file manager into the group [Default Applications]

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120565/#review68305
-----------------------------------------------------------

Ship it!


Looks correct. The addition to "Added Applications" is obsoleted by this, I guess you're keeping it for old implementations, that's fine.

Hmm, well, kservice/src/kbuildsycoca/kmimeassociations.cpp is such an "old" implementation, it doesn't read Default Applications yet :-)
That's something else you might want to fix ;)

- David Faure


On Oct. 12, 2014, 6:03 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120565/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2014, 6:03 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Save the default file manager (inode/directory) by writing into the group [Default Applications] in the file mimeapps.list, as per the mime-apps spec 1.0.1 .
> http://standards.freedesktop.org/mime-apps-spec/mime-apps-spec-1.0.1.html#default
> 
> keditfiletype (kde-cli-tools) already saves the default application for a given mimetype (including inode/directory for file manager) in [Default Applications] since
> http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=32bf8f704f174f2652aadf442b07fb10c597a327
> 
> regards,
> 
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change if the patch looks fine. Thanks.
> 
> 
> Diffs
> -----
> 
>   kcms/componentchooser/componentchooserfilemanager.cpp b23bfa0 
> 
> Diff: https://git.reviewboard.kde.org/r/120565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141013/d3d12282/attachment-0001.html>