Review Request 120566: Remove CMake cruft.
Michael Palimaka
kensington at gentoo.org
Mon Oct 13 06:30:31 UTC 2014
> On Oct. 12, 2014, 11:37 p.m., Aleix Pol Gonzalez wrote:
> > What do you mean by "toggle find_package"?
-DCMAKE_DISABLE_FIND_PACKAGE_Phonon4Qt5. This is consistent approach with other optional dependencies.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120566/#review68294
-----------------------------------------------------------
On Oct. 12, 2014, 6:47 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120566/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 6:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Since we can toggle find_package natively, we no longer need these old manual switches.
>
>
> Diffs
> -----
>
> phonon/CMakeLists.txt fee6f287e4b75fdb83356e5c868f43ac30f76392
>
> Diff: https://git.reviewboard.kde.org/r/120566/diff/
>
>
> Testing
> -------
>
> Builds enabled/disabled as expected.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141013/06fd1e5e/attachment.html>
More information about the Plasma-devel
mailing list