DialogNativeTest::position() breakage

Marco Martin notmart at gmail.com
Sat Oct 11 19:02:30 UTC 2014


On Saturday 11 October 2014 12:41:43 David Faure wrote:
> Can a plasma developer look into this?
> 
> http://build.kde.org/job/plasma-framework_master_qt5/830/Variation=All,label
> =LINBUILDER/testReport/(root)/TestSuite/dialognativetest/
> 
> Broken for one week now.
> 
> FAIL!  : DialogNativeTest::position() Compared values are not the same
>    Actual   (m_dialog->x()): 71
>    Expected (73)           : 73
>    Loc:
> [/srv/jenkins/workspace/plasma-framework_master_qt5/Variation/All/label/LIN
> BUILDER/autotests/dialognativetest.cpp(69)]

actually, 71 is the correct value.
i did a bisect, and i seen that before 419b344b6 (when the test broke)
the dialog size was actually wrong, leading to a different position.

i added a test on the size as well to make sure this doesn't happen again

-- 
Marco Martin


More information about the Plasma-devel mailing list