Review Request 120538: Update default applications in kickoff

[Martin Klapetek]

> On Oct. 9, 2014, 11:06 a.m., Kai Uwe Broulik wrote:
> > Can't this be deduced from the default browser or default application to handle text/html? That way it will always be the distribution's preferred browser.
> 
> Sebastian Kügler wrote:
>     The default browser is known by executable name, so we'd still need to get the service for it, and use that (for icon, readable name, and so on). So I think this way of doing it is correct.
> 
> Martin Klapetek wrote:
>     Right, but you'd get the default browser executable first rather than our own predefined list (which I think was Kai's point)
> 
> Sebastian Kügler wrote:
>     Can't say that I understand completely, but yes, there's a difference between mimetype handler voor text/html and default browser? (They're set up differently, at least.)

To reiterate then - find out the default browser either from the default browser setting or from the first text/html handler, instead of setting predefined priority to the browsers ourselves and choosing the first one that was found. An example: user has Chromium as default but also has installed Firefox, this code would put Firefox in his favorites even though his default browser is Chromium. So it would make more sense to put Chromium there rather than Firefox, which was simply before Chromium in the list in this patch.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120538/#review68111
-----------------------------------------------------------


On Oct. 9, 2014, 10:41 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120538/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 10:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> instead of defaulting to konqueror find the first browser from a list
> change konsole to ktp-contactlist, we want to appeal to non geeks
> change kmail for kontact, we provide a lovely PIM suite so we should show it by default
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/favoritesmodel.cpp e26cf802a186b5a0f7627124ee1013e8b022bfe2 
> 
> Diff: https://git.reviewboard.kde.org/r/120538/diff/
> 
> 
> Testing
> -------
> 
> make a new user, start up plasma
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141009/e27ac5fb/attachment.html>