Review Request 120533: Read/Write ColorScheme to configGroup General instead of KDE

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120533/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

Read/Write ColorScheme to configGroup General instead of KDE

commit d59d611731e293f06ce24361aff79fb02554987f changed one of the many
places this group is used. I think it was a correct change.

This fixes all the other places.


Diffs
-----

  kcms/lookandfeel/autotests/kcmtest.cpp 83dcb40 
  kcms/lookandfeel/autotests/lookandfeel/contents/defaults ebafb42 
  kcms/lookandfeel/kcm.cpp 2b61412 

Diff: https://git.reviewboard.kde.org/r/120533/diff/


Testing
-------

Tests pass (note I had to wipe ~/.qttest as plasmapackage doesn't reinstall if it detects the old lookandfeel package in there)
Not tested the KCM properly.

I /think/ that WidgetStyle belongs in General rather than KDE too. My KDE4 kdeglobals config certainly looks like that; my KF5 one has it in both places.. probably due to this KCM so I can't really tell what's correct. 

(note I am traveling tomorrow. Marco, if this looks sensible please could you merge it for me)


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141008/1d2f91d5/attachment.html>