Review Request 120441: [libksysguard] Get rid of KDELibs4Support
    Hrvoje Senjan 
    hrvoje.senjan at gmail.com
       
    Tue Oct  7 15:36:46 UTC 2014
    
    
  
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120441/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 5:36 p.m.)
Review request for Plasma.
Changes
-------
fixed issues, except categorized logging - will open a separate review for that one
Repository: libksysguard
Description
-------
some libs needed just headers removal, other something more ...
found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it.
Diffs (updated)
-----
  CMakeLists.txt 61bd704 
  ksgrd/CMakeLists.txt 64ad24a 
  ksgrd/SensorManager.cpp 9e1534a 
  lsofui/CMakeLists.txt 2b0c8ac 
  lsofui/lsof.h e87ac26 
  processcore/CMakeLists.txt 0ca833e 
  processcore/processes.cpp 3e63218 
  processcore/processes_atop_p.cpp 369df36 
  processcore/processes_remote_p.cpp 361bf24 
  processui/CMakeLists.txt 150e198 
  processui/KTextEditVT.cpp 064737b 
  processui/ProcessFilter.cpp b37766e 
  processui/ProcessModel.cpp 8b87d41 
  processui/ProcessModel_p.h 6bc9d09 
  processui/ReniceDlg.h fa445a5 
  processui/ReniceDlg.cpp 218412c 
  processui/ksysguardprocesslist.cpp d3403cc 
  processui/scripting.cpp fd0a610 
  signalplotter/CMakeLists.txt 67aa8bb 
  signalplotter/kgraphicssignalplotter.h 9f698d4 
  signalplotter/ksignalplotter.cpp 91d9eee 
  tests/CMakeLists.txt a74c6a2 
  tests/graphicssignalplotterbenchmark.cpp e27eb1a 
  tests/ksysguarddtest.cpp cd0c8bd 
  tests/processtest.cpp 6aa9809 
  tests/signalplotterbenchmark.cpp 8b827d6 
  tests/signalplottertest.cpp bb2108e 
Diff: https://git.reviewboard.kde.org/r/120441/diff/
Testing
-------
builds, tests pass, ksysguard functions as it did
Thanks,
Hrvoje Senjan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141007/b99e1040/attachment.html>
    
    
More information about the Plasma-devel
mailing list