Review Request 120471: Add Registry::sync() signal

Sebastian Kügler sebas at kde.org
Tue Oct 7 09:12:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120471/
-----------------------------------------------------------

(Updated Oct. 7, 2014, 9:12 a.m.)


Review request for kwin, Plasma and Martin Gräßlin.


Changes
-------

    Don't leak wl_callback
    
    * Properly clean up the sync callback when registry is released or
    destroyed
    * Rename signal from Registry::sync() to interfacesAnnounced()


Repository: kwayland


Description
-------

Add Registry::sync() signal

Emitted when the Wayland display is done flushing the initial interface
callbacks, announcing wl_display properties. This can be used to compress
events. Note that this signal is emitted only after announcing interfaces,
such as outputs, but not after receiving callbacks of interface properties,
such as the output's geometry, modes, etc..
This signal is emitted from the wl_display_sync callback.

For this, we add a wl_callback_listener to the registry's Private,
enqueue its events properly, if necessary, and trigger the signal
through a callback mechanism similar to the wl_registry callbacks.

This signal allows users of the API to find out when the signal
emissions, such as outputAnnounced, etc. for all currently existing
interfaces is complete.


Diffs (updated)
-----

  autotests/client/test_wayland_registry.cpp 571be0f 
  src/client/registry.h 9e63a2b 
  src/client/registry.cpp 22f9484 

Diff: https://git.reviewboard.kde.org/r/120471/diff/


Testing
-------

tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141007/e7e011e3/attachment-0001.html>


More information about the Plasma-devel mailing list