Review Request 120516: introduce bool applicationMode for standalone application mode

Marco Martin notmart at gmail.com
Tue Oct 7 08:11:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120516/#review68039
-----------------------------------------------------------



shell/desktopview.h
<https://git.reviewboard.kde.org/r/120516/#comment47425>

    don't put a NOTIFY, just a CONSTANT without signal



shell/desktopview.h
<https://git.reviewboard.kde.org/r/120516/#comment47426>

    even the setter and the internal variable is not necessary, you can just check if m_corona is a shellcorona or not


- Marco Martin


On Ott. 7, 2014, 4:24 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120516/
> -----------------------------------------------------------
> 
> (Updated Ott. 7, 2014, 4:24 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this can be used by shell package to know if it is opened in application mode or full shell
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.h 1b07261 
>   shell/desktopview.cpp dcd002d 
>   shell/standaloneappcorona.cpp dd9b69b 
> 
> Diff: https://git.reviewboard.kde.org/r/120516/diff/
> 
> 
> Testing
> -------
> 
> tested with pmc
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141007/a1811763/attachment.html>


More information about the Plasma-devel mailing list