Review Request 120441: [libksysguard] Get rid of KDELibs4Support

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120441/#review68025
-----------------------------------------------------------


Minor issues and +1 to Martin G's note about commented out debugs...imo they should just go


signalplotter/ksignalplotter.cpp
<https://git.reviewboard.kde.org/r/120441/#comment47415>

    This should probably be qCDebug to keep the category



tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120441/#comment47416>

    Is the I18n still needed here in the tests linkage? I see only the signalplottertest.cpp using i18n (and even that usage could possibly be removed but meh, it's just tests)


- Martin Klapetek


On Oct. 6, 2014, 6:29 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120441/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 6:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> some libs needed just headers removal, other something more ...
> found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 61bd704 
>   ksgrd/CMakeLists.txt 64ad24a 
>   ksgrd/SensorManager.cpp 9e1534a 
>   lsofui/CMakeLists.txt 2b0c8ac 
>   lsofui/lsof.h e87ac26 
>   processcore/CMakeLists.txt 0ca833e 
>   processcore/processes.cpp 3e63218 
>   processcore/processes_atop_p.cpp 369df36 
>   processcore/processes_remote_p.cpp 361bf24 
>   processui/CMakeLists.txt 150e198 
>   processui/KTextEditVT.cpp 064737b 
>   processui/ProcessFilter.cpp b37766e 
>   processui/ProcessModel.cpp 8b87d41 
>   processui/ProcessModel_p.h 6bc9d09 
>   processui/ReniceDlg.h fa445a5 
>   processui/ReniceDlg.cpp 218412c 
>   processui/ksysguardprocesslist.cpp d3403cc 
>   processui/scripting.cpp fd0a610 
>   signalplotter/CMakeLists.txt 67aa8bb 
>   signalplotter/kgraphicssignalplotter.h 9f698d4 
>   signalplotter/ksignalplotter.cpp 91d9eee 
>   tests/CMakeLists.txt a74c6a2 
>   tests/graphicssignalplotterbenchmark.cpp e27eb1a 
>   tests/processtest.cpp 6aa9809 
>   tests/signalplotterbenchmark.cpp 8b827d6 
>   tests/signalplottertest.cpp bb2108e 
> 
> Diff: https://git.reviewboard.kde.org/r/120441/diff/
> 
> 
> Testing
> -------
> 
> builds, tests pass, ksysguard functions as it did
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141006/0e0674bb/attachment.html>