Review Request 120489: Hide PrograssBar inner item when value is 0
David Edmundson
david at davidedmundson.co.uk
Sat Oct 4 20:38:47 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120489/#review67932
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Oct. 4, 2014, 8:27 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120489/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2014, 8:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> To prevent the SvgItem from leaking outside, there is a minimum size (being the margins) enforced. This leads to the situation where an empty progress bar still shows a little spot on the left. This patch fixes this.
>
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qml/ProgressBar.qml b872c97
>
> Diff: https://git.reviewboard.kde.org/r/120489/diff/
>
>
> Testing
> -------
>
> Change brightness to zero, no more couple of pixels area in the progress bar.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141004/106ae23d/attachment.html>
More information about the Plasma-devel
mailing list