10000 lines change in kdeplasma-addons 4.14 branch

[Albert Astals Cid]

El Dijous, 2 d'octubre de 2014, a les 16:41:38, Weng Xuetian va escriure:
> Hi,
> Sorry for all the trouble.
> 
> Sho on irc asked me that he want to test the ibus 1.5 support easier so I
> get it merged for kde4. Unfortunately there's no further kdeplamsa-addons
> for kde4 and I didn't finish this before 4.14, so it's also either leave it
> broken in kde4 or add a usable version.

With my release team hat on, i would have really welcome a you asking *before* 
you do such a big commit in a stable branch.

It is not my fault Plasma people decided to not have any more kdeplasma 
feature releases, a new feature in a stable branch is a new feature in a 
stable branch and it needs an exception.

With your explanation i don't think we should reject the exception, but 
seriously, some communication never hurts.

Please everyone understand that we have stable branches for a reason, and 
adding 10K lines in them is usually not the reason.

For me we can leave this as it is, but please  next time you need to commit 
such a big chunk of code to a stable branch talk to people on a mailing list 
and ideally the release team.

Now let's all go back to do amazing work :)

Cheers,
  Albert