Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121298/#review71136
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 30, 2014, 9:46 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121298/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 9:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.
> 
> 
> Diffs
> -----
> 
>   attica-kde/kdeplugin/kdeplatformdependent.cpp 4ade04c85db0c3efc0070bd0f288b16f3bd5882e 
> 
> Diff: https://git.reviewboard.kde.org/r/121298/diff/
> 
> 
> Testing
> -------
> 
> Before this change any application that used knewstuff (and thus this plugin) showing a dialog would get -- attica_kde in the titlebar of the dialog. (run kanagram or blinken and show the about dialog to see).
> With this change it correctly shows the application name there instead.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141130/245ccd47/attachment.html>