Review Request 121228: Fix minimum height in notifications

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121228/
-----------------------------------------------------------

(Updated Nov. 25, 2014, 11:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Martin Klapetek and Vishesh Handa.


Bugs: 341218
    https://bugs.kde.org/show_bug.cgi?id=341218


Repository: plasma-workspace


Description
-------

This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, text) + margins which should fix the layout in case the notification has no bodytext.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationItem.qml 1074e63 

Diff: https://git.reviewboard.kde.org/r/121228/diff/


Testing
-------

Nope, no 5 here, hence the RR :)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141125/26f4aa9e/attachment.html>