Review Request 121239: Port ktouchpadenabler

[Albert Astals Cid]

> On nov. 25, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 135
> > <https://git.reviewboard.kde.org/r/121239/diff/1/?file=329683#file329683line135>
> >
> >     Maybe if(KF5WindowSystem_VERSION VERSION_GREATER 5.5)?

As said, there's no need, it will still compile, and once the system has kwindowsystem 5.5 it will just work without any recompilation needed, so adding the if is actually detrimental.


> On nov. 25, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > ktouchpadenabler/ktouchpadenabler_daemon.cpp, line 231
> > <https://git.reviewboard.kde.org/r/121239/diff/1/?file=329685#file329685line231>
> >
> >     weird indentation? =.='

Yeah will fix.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121239/#review70888
-----------------------------------------------------------


On nov. 25, 2014, 12:12 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121239/
> -----------------------------------------------------------
> 
> (Updated nov. 25, 2014, 12:12 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Unless used with kwindowsystem 5.5 it won't work (but will still compile)
> Unless used with "a really new Qt" (i.e. when https://codereview.qt-project.org/#/c/100200/ finally integrates) the system settings kcm will say "¶?" instead of "Touchpad Toggle" (but it will work just fine)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6612aa4 
>   ktouchpadenabler/CMakeLists.txt 1e46605 
>   ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b 
>   ktouchpadenabler/settings.kcfgc 9e49060 
> 
> Diff: https://git.reviewboard.kde.org/r/121239/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141125/77c0006a/attachment.html>