Review Request 121236: Minimize overdraw in Desktop view

Aleix Pol Gonzalez aleixpol at kde.org
Tue Nov 25 00:09:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121236/#review70885
-----------------------------------------------------------

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Nov. 24, 2014, 9:07 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121236/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 9:07 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This changes the root item to be Item and only shows a black Rectangle when dashboard is shown. Together with Review 121162 there is only ever one full-sized root item (used to be three and more).
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/views/Desktop.qml 73698f6 
> 
> Diff: https://git.reviewboard.kde.org/r/121236/diff/
> 
> 
> Testing
> -------
> 
> Should look like it did before, however, when the dashboard is shown ontop of a light maximized window (browser) the contrast is too low imho (don't remember if that was the case before that). Plasmoidviewer also looks normal (eg. no transparent spots when resizing the window)
> 
> Also, when switching wallpaper plugins (like from image to color) the transparency in the dashboard is gone. Afaics this has been the case without this patch as well but I failed to fix it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141125/b7b5fe88/attachment.html>


More information about the Plasma-devel mailing list