Review Request 121207: Port the notes editor to KDevPlatform

Aleix Pol Gonzalez aleixpol at kde.org
Mon Nov 24 23:49:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121207/#review70880
-----------------------------------------------------------


Again, why not in the document view? Note that you can change the tab title if you consider it needed, but to me it looks like a README editor...?

- Aleix Pol Gonzalez


On Nov. 22, 2014, 3:53 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121207/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 3:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> This is a simple port of the noteseditor to KDevPlatform.
> The internals have remained the same.
> 
> Also I have attached an image showing the noteseditor inside
> KDevelop
> 
> 
> Diffs
> -----
> 
>   plasmate/noteseditor/noteseditor.h 2176456 
>   plasmate/noteseditor/noteseditor.cpp 6118d4e 
>   plasmate/plugins/CMakeLists.txt 410080b 
>   plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION 
>   plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION 
>   plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION 
>   plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121207/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> noteseditor in kdevelop
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141124/0e3288f7/attachment.html>


More information about the Plasma-devel mailing list