Review Request 121229: Highlight first entry when searching

[Aleix Pol Gonzalez]

> On Nov. 24, 2014, 5:36 p.m., Aleix Pol Gonzalez wrote:
> > Definitely, does pressing up & down work as expected too?
> > 
> > In fact, here it looks like I already get a highlight delegate...
> 
> Kai Uwe Broulik wrote:
>     Yes, pressing up and down works as expected, only if you type again (which resets the list anyway) you end up at the top again.
>     
>     Make sure you don't have your mouse hovering there, I had the same and thought it already worked :)

I made sure. But your patch seems to make sense and fix the bug, so +1.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/#review70859
-----------------------------------------------------------


On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121229/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 5:27 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 340067
>     https://bugs.kde.org/show_bug.cgi?id=340067
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Since pressing enter invokes the first entry it should be highlighted.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 
> 
> Diff: https://git.reviewboard.kde.org/r/121229/diff/
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141124/0453a712/attachment.html>