Review Request 121228: Fix minimum height in notifications
Kai Uwe Broulik
kde at privat.broulik.de
Mon Nov 24 15:29:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121228/
-----------------------------------------------------------
Review request for Plasma, Martin Klapetek and Vishesh Handa.
Bugs: 341218
https://bugs.kde.org/show_bug.cgi?id=341218
Repository: plasma-workspace
Description
-------
This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, text) + margins which should fix the layout in case the notification has no bodytext.
Diffs
-----
applets/notifications/package/contents/ui/NotificationItem.qml 1074e63
Diff: https://git.reviewboard.kde.org/r/121228/diff/
Testing
-------
Nope, no 5 here, hence the RR :)
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141124/0d41be6b/attachment.html>
More information about the Plasma-devel
mailing list