Review Request 121155: Enforce StyledText in notifications

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121155/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 8:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek.


Bugs: 341029
    https://bugs.kde.org/show_bug.cgi?id=341029


Repository: plasma-workspace


Description
-------

According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says "each line is a paragraph" a <br> is added for each line break instead.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 
  applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 
  applets/notifications/package/contents/ui/Notifications.qml 4312774 

Diff: https://git.reviewboard.kde.org/r/121155/diff/


Testing
-------

Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like <user> said something.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/e19fbadc/attachment.html>