Review Request 121152: Provide async API for QmlObject

Marco Martin notmart at gmail.com
Tue Nov 18 17:39:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/#review70599
-----------------------------------------------------------



src/kdeclarative/qmlobject.h
<https://git.reviewboard.kde.org/r/121152/#comment49413>

    I think this method can be avoided, and have an internal private slot called instead when initializationDelayed is true


- Marco Martin


On Nov. 17, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121152/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 4:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Introduces a method called ::delayedCompleteInitialization that will trigger the initialization then notify when it's done.
> 
> Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of limitations in reviewboard.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 
>   src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 
> 
> Diff: https://git.reviewboard.kde.org/r/121152/diff/
> 
> 
> Testing
> -------
> 
> See https://git.reviewboard.kde.org/r/121148/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/096553ad/attachment.html>


More information about the Plasma-devel mailing list