Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

Sebastian Kügler sebas at kde.org
Tue Nov 18 14:08:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121086/#review70583
-----------------------------------------------------------



thumbnail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121086/#comment49407>

    whitespace


What I'm missing is migration of the setting, is that relevant, any other reason why it's missing?

- Sebastian Kügler


On Nov. 9, 2014, 4:09 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121086/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 4:09 p.m.)
> 
> 
> Review request for KDE Runtime, KDE Frameworks and Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Simply add 5 as a suffix to avoid conflicts with KDE 4 version which
> is shipped in KDE-Runtime which isn't going away any time now.
> 
> 
> Diffs
> -----
> 
>   thumbnail/CMakeLists.txt e9ab79b 
>   thumbnail/jpegcreator.cpp de4902b 
>   thumbnail/jpegcreatorsettings.kcfg 8f68f46 
>   thumbnail/jpegcreatorsettings.kcfgc 3f6cdab 
>   thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION 
>   thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/a35add5f/attachment.html>


More information about the Plasma-devel mailing list