Review Request 120970: Remove combo "Graphical Effects"

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review70582
-----------------------------------------------------------

Ship it!


I think we're all cool with removing this particular combobox (thanks Martin!), it's useless and its implementation is broken. We can always discuss bringing some kind of eye-candy-o-meter back, this patch can go in already.

- Sebastian Kügler


On Nov. 4, 2014, 10:55 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 10:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -----
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/17e091e8/attachment.html>