Review Request 121144: Remove MetadaBackendCommonModel

Shantanu Tushar shantanu at kde.org
Mon Nov 17 06:01:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/#review70498
-----------------------------------------------------------

Ship it!


Ship It!

- Shantanu Tushar


On Nov. 17, 2014, 5:55 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121144/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 5:55 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> this was just a wrapper around PmcMetadataModel and was not doing anything
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatavideobackend/metadatavideomodel.h 3e85f4a 
>   browsingbackends/metadatavideobackend/metadatavideomodel.cpp 417cddd 
>   browsingbackends/metadatabackendcommonmodel.h 0873bc0 
>   browsingbackends/metadatabackendcommonmodel.cpp fbee1ff 
>   browsingbackends/metadatamusicbackend/CMakeLists.txt 48e98ea 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.h 836ee21 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp d9f4fa6 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h 53efbd2 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.cpp 55debf0 
>   browsingbackends/metadatavideobackend/CMakeLists.txt 2b81ab2 
>   browsingbackends/metadatavideobackend/metadatavideobackend.cpp 1ed833d 
> 
> Diff: https://git.reviewboard.kde.org/r/121144/diff/
> 
> 
> Testing
> -------
> 
> everything works fine without it
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141117/e0d5b655/attachment.html>


More information about the Plasma-devel mailing list