Review Request 121130: Remove okToLoad method of backend
Shantanu Tushar
shantanu at kde.org
Sun Nov 16 03:08:01 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121130/#review70417
-----------------------------------------------------------
Ship it!
Ship It!
- Shantanu Tushar
On Nov. 15, 2014, 4:12 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121130/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2014, 4:12 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> This was case for local filebrowsing on plasma active but since we already removed localfile browsing backends remove this method
>
> I cross checked this with other backends that might need such use case but I think those backends can return false in initImpl or choose not to give any data
>
>
> Diffs
> -----
>
> libs/mediacenter/abstractbrowsingbackend.h 3a9dbea
> libs/mediacenter/abstractbrowsingbackend.cpp f770759
> libs/mediacenter/backendsmodel.cpp a4fff82
>
> Diff: https://git.reviewboard.kde.org/r/121130/diff/
>
>
> Testing
> -------
>
> compiles fine
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141116/87278866/attachment.html>
More information about the Plasma-devel
mailing list