Review Request 121133: Fix qml warnings in splash kcm
Albert Astals Cid
aacid at kde.org
Sat Nov 15 20:54:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121133/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Warnings where
file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: QML Text: Cannot anchor to an item that isn't a parent or sibling.
file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:77:33: Unable to assign [undefined] to QUrl
file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: QML Text: Cannot anchor to an item that isn't a parent or sibling.
Since anchoring to non parent/sibling doesn't do anything i've just removed the anchoring.
I've fixed the undefined by adding || ""
Diffs
-----
kcms/splash/package/contents/ui/main.qml 9c8fed0
Diff: https://git.reviewboard.kde.org/r/121133/diff/
Testing
-------
Warnings are gone, dialog looks the same.
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141115/37735e85/attachment.html>
More information about the Plasma-devel
mailing list