Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

[Ian Wadham]

> On Nov. 11, 2014, 10:43 p.m., Hrvoje Senjan wrote:
> > 5.1.1 out. should 5(.1.x) be targeted at all?
> 
> Thomas Lübking wrote:
>     As this is now a straightforward port of what there is in KDE SC 4 and DrKonqui is atm. useless and crashreports for KF/5 currently suck in 80% of all cases (not the users fault - they say "crash" and post the shell output ;-)
>     
>        I clearly vote for pushing it into 5.1
>        
>     Findings on whether a certain method can be hardcoded and other improvements then would point 5.2 or whatever else.
>     I'm however not sure whether we should abandon the bugzilla version check + depending security stuff so easily.
>     Once because as Ian mentioned there might be interest in extending KCrash to allow different bugzilla servers (evtl. even move it to Tier1).
>     And also because one cannot be sure that bugzilla does not jump onto yet another security bandwagon with the release after the next one.
> 
> Hrvoje Senjan wrote:
>     thanks. unless then someone yells not to push, will commit in a few hours.

Thanks very much for your help, Hrvoje.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/#review70263
-----------------------------------------------------------


On Nov. 12, 2014, 6:57 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120876/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 6:57 p.m.)
> 
> 
> Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.
> 
> 
> Bugs: 337742
>     https://bugs.kde.org/show_bug.cgi?id=337742
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> discussion was in https://git.reviewboard.kde.org/r/120431/
> removed the version checks, as we know we have kdelibs >= 4.5 ;-)
> 
> 
> Diffs
> -----
> 
>   drkonqi/bugzillaintegration/bugzillalib.h 570169b 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f 
> 
> Diff: https://git.reviewboard.kde.org/r/120876/diff/
> 
> 
> Testing
> -------
> 
> builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141114/8127e33e/attachment.html>