Review Request 121121: Remove all kdelibs4support from polkit-agent
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Nov 14 17:24:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/#review70375
-----------------------------------------------------------
+1, looks good, maintainers will know best.
- Aleix Pol Gonzalez
On Nov. 14, 2014, 5:08 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121121/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 5:08 p.m.)
>
>
> Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.
>
>
> Repository: polkit-kde-agent-1
>
>
> Description
> -------
>
> Remove all kdelibs4support from polkit-agent
>
>
> Diffs
> -----
>
> AuthDialog.h eaebbd2
> AuthDialog.cpp b76d91e
> AuthDialog.ui e4da0f9
> CMakeLists.txt 482fc57
> main.cpp f8f97b8
> policykitkde.h 85ce6b2
> policykitkde.cpp a25cb4f
> policykitlistener.h 538381f
> policykitlistener.cpp bab7fdf
>
> Diff: https://git.reviewboard.kde.org/r/121121/diff/
>
>
> Testing
> -------
>
> Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141114/79520d90/attachment-0001.html>
More information about the Plasma-devel
mailing list