Review Request 121119: add possibility for l&f package to have layouts

Bhushan Shah bhush94 at gmail.com
Fri Nov 14 14:48:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121119/#review70365
-----------------------------------------------------------


is bah.diff part of this review?

- Bhushan Shah


On Nov. 14, 2014, 8:13 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121119/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 8:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> if the l&f package has a default layout script, make it win over the one of the shell.
> this should be used for distributions to customize.
> 
> since there can be one l&f package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp 1ea0c90 
> 
> Diff: https://git.reviewboard.kde.org/r/121119/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> bah.diff
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/14/8b4c5430-dda2-42ca-9cd8-d06fdff09210__bah.diff
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141114/4ea1fc5f/attachment.html>


More information about the Plasma-devel mailing list