Review Request 121105: Show notification configure button only if application actually has configurable notifications
Bhushan Shah
bhush94 at gmail.com
Wed Nov 12 08:05:41 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121105/#review70268
-----------------------------------------------------------
Ship it!
Ship It!
- Bhushan Shah
On Nov. 11, 2014, 11:20 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121105/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 11:20 p.m.)
>
>
> Review request for Plasma, Emmanuel Pescosta, Eike Hein, and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This patch makes notifications only show the configure button if the application actually has configurable notifications, adapted from KNotifyEventList::fill().
>
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.h 40155f2
> dataengines/notifications/notificationsengine.cpp 06233e9
>
> Diff: https://git.reviewboard.kde.org/r/121105/diff/
>
>
> Testing
> -------
>
> Plasmashell's undo notification and NM notifications still have working configure whereas KMail does not (the dialog was empty previously)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141112/7f6112c6/attachment.html>
More information about the Plasma-devel
mailing list