Review Request 121105: Show notification configure button only if application actually has configurable notifications

Kai Uwe Broulik kde at privat.broulik.de
Tue Nov 11 17:50:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121105/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 5:50 nachm.)


Review request for Plasma, Emmanuel Pescosta, Eike Hein, and Martin Klapetek.


Changes
-------

Save configurable state

Adding Emmanuel because he's the container expert :)


Repository: plasma-workspace


Description
-------

This patch makes notifications only show the configure button if the application actually has configurable notifications, adapted from KNotifyEventList::fill().


Diffs (updated)
-----

  dataengines/notifications/notificationsengine.h 40155f2 
  dataengines/notifications/notificationsengine.cpp 06233e9 

Diff: https://git.reviewboard.kde.org/r/121105/diff/


Testing
-------

Plasmashell's undo notification and NM notifications still have working configure whereas KMail does not (the dialog was empty previously)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141111/bee6adc2/attachment.html>


More information about the Plasma-devel mailing list