Review Request 120949: Add imageprovider to fifteenpuzzle.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/#review70206
-----------------------------------------------------------

Ship it!


Fine with me. 

Check Marco is happy as he didn't seem to pleased at first.


applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp
<https://git.reviewboard.kde.org/r/120949/#comment49090>

    This leaks, parent it to the engine.


- David Edmundson


On Nov. 6, 2014, 2:23 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120949/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 2:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
> but need to come from the qml. This is a first attempt posting to get
> feedback about the approach etc.
> 
> 
> Diffs
> -----
> 
>   applets/fifteenPuzzle/package/contents/ui/main.qml c76eaeb4d936fe917d99375722905c2f002c33e6 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
>   applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
>   applets/fifteenPuzzle/package/contents/config/main.xml 0dd804a12ddb0c7c2daaced1b92582f0deff494f 
>   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml bf9581bd78c1c7690fc16f01e440adad0fc98766 
>   applets/fifteenPuzzle/package/contents/ui/Piece.qml c386570aebdf4323e3132aa05445b38383149dea 
>   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
> 
> Diff: https://git.reviewboard.kde.org/r/120949/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs, currently doesn't shuffle, to test the result image works and appears.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/4a44e119/attachment-0001.html>