Review Request 121057: Refactor JobDelegate

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121057/#review70201
-----------------------------------------------------------

Ship it!


Looks good!


applets/notifications/package/contents/ui/JobDelegate.qml
<https://git.reviewboard.kde.org/r/121057/#comment49088>

    Functions should go below properties; inherited properties should in turn be first (see the QML coding style for Plasma)



applets/notifications/package/contents/ui/JobDetailsItem.qml
<https://git.reviewboard.kde.org/r/121057/#comment49089>

    i18nc?


- Martin Klapetek


On Nov. 7, 2014, 10:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121057/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 10:11 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch basically turns the entire code upside down :)
> 
> - All of this ugly conditional anchoring has been replaced by layouts where applicable
> - the details have been outsourced into a separate file which is loaded conditionally and should improve performance because all those bindings (processed amount changed, speed changed, etc) are not evaluated if the thing isn't expanded
> - reduces code duplication by using fancy Repeaters
> - removes commented code
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDelegate.qml 14bdd63 
>   applets/notifications/package/contents/ui/JobDetailsItem.qml PRE-CREATION 
>   applets/notifications/package/contents/ui/Jobs.qml 6e457e3 
> 
> Diff: https://git.reviewboard.kde.org/r/121057/diff/
> 
> 
> Testing
> -------
> 
> Should look the same, copied a bunch of large folders (we really need a test application that mimics a file copy job...)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/a8e02685/attachment.html>