Review Request 121071: Give undo notification a title

[Sebastian Kügler]

> On Nov. 10, 2014, 9:45 a.m., Sebastian Kügler wrote:
> > src/plasma/private/applet_p.cpp, line 248
> > <https://git.reviewboard.kde.org/r/121071/diff/1/?file=327256#file327256line248>
> >
> >     panel lowercase?
> 
> Kai Uwe Broulik wrote:
>     Actually Removed should be uppercase too, it should be title capitalization but I don't know the exact rules - maybe David Edmundson knows.

the Removed is fine. That's correctly title-capitalized.

The other bit is "plain text", which should be capilatized according to normal rules. We have a HIG page about capitalization, which I find very useful: https://techbase.kde.org/Projects/Usability/HIG/Capitalization


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121071/#review70172
-----------------------------------------------------------


On Nov. 8, 2014, 6:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121071/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 6:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The "Plasma" (default put in there by the notification applet because it has no title) is not really descriptive. It's a bit duplication now but better imho.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp a4f7c1c 
> 
> Diff: https://git.reviewboard.kde.org/r/121071/diff/
> 
> 
> Testing
> -------
> 
> Deleted a widget and a panel.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/3ee511bf/attachment.html>