Review Request 121071: Give undo notification a title
Sebastian Kügler
sebas at kde.org
Mon Nov 10 09:45:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121071/#review70172
-----------------------------------------------------------
src/plasma/private/applet_p.cpp
<https://git.reviewboard.kde.org/r/121071/#comment49084>
panel lowercase?
src/plasma/private/applet_p.cpp
<https://git.reviewboard.kde.org/r/121071/#comment49083>
Unrelated to this patch -- desktop should be lowercase here, no?
- Sebastian Kügler
On Nov. 8, 2014, 6:19 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121071/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 6:19 p.m.)
>
>
> Review request for Plasma, Marco Martin and Martin Klapetek.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The "Plasma" (default put in there by the notification applet because it has no title) is not really descriptive. It's a bit duplication now but better imho.
>
>
> Diffs
> -----
>
> src/plasma/private/applet_p.cpp a4f7c1c
>
> Diff: https://git.reviewboard.kde.org/r/121071/diff/
>
>
> Testing
> -------
>
> Deleted a widget and a panel.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/8f13c1f8/attachment.html>
More information about the Plasma-devel
mailing list